From issues-return-172480-apmail-maven-issues-archive=maven.apache.org@maven.apache.org Mon Sep 7 19:31:01 2020 Return-Path: X-Original-To: apmail-maven-issues-archive@locus.apache.org Delivered-To: apmail-maven-issues-archive@locus.apache.org Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by minotaur.apache.org (Postfix) with ESMTP id D4BBA1A2A7 for ; Mon, 7 Sep 2020 19:31:01 +0000 (UTC) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 93AA94289B for ; Mon, 7 Sep 2020 19:31:01 +0000 (UTC) Received: (qmail 84855 invoked by uid 500); 7 Sep 2020 19:31:01 -0000 Delivered-To: apmail-maven-issues-archive@maven.apache.org Received: (qmail 84801 invoked by uid 500); 7 Sep 2020 19:31:01 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 84789 invoked by uid 99); 7 Sep 2020 19:31:01 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Sep 2020 19:31:01 +0000 From: =?utf-8?q?GitBox?= To: issues@maven.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bmaven-ear-plugin=5D_mabrarov_commented_on_a_change?= =?utf-8?q?_in_pull_request_=2310=3A_=5BMEAR-283=5D_Reproducible_builds_with?= =?utf-8?q?_skinnyWars_option?= Message-ID: <159950706101.32230.455213227415973784.asfpy@gitbox.apache.org> Date: Mon, 07 Sep 2020 19:31:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: mabrarov commented on a change in pull request #10: URL: https://github.com/apache/maven-ear-plugin/pull/10#discussion_r484549347 ########## File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java ########## @@ -284,7 +285,33 @@ public void execute() // Initializes ear modules super.execute(); + final File earFile; Review comment: I'm afraid that if we expand try block then we will change the way exceptions are handled. So the answer is: no, we cannot if we don't want to dive into details on how existing code handles exceptions :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org