From issues-return-172798-apmail-maven-issues-archive=maven.apache.org@maven.apache.org Tue Sep 15 06:13:06 2020 Return-Path: X-Original-To: apmail-maven-issues-archive@locus.apache.org Delivered-To: apmail-maven-issues-archive@locus.apache.org Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by minotaur.apache.org (Postfix) with ESMTP id DECCF19C3D for ; Tue, 15 Sep 2020 06:13:05 +0000 (UTC) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id E6B0C63B02 for ; Tue, 15 Sep 2020 06:13:04 +0000 (UTC) Received: (qmail 3857 invoked by uid 500); 15 Sep 2020 06:13:04 -0000 Delivered-To: apmail-maven-issues-archive@maven.apache.org Received: (qmail 3802 invoked by uid 500); 15 Sep 2020 06:13:02 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 3771 invoked by uid 99); 15 Sep 2020 06:13:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Sep 2020 06:13:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D85124288F for ; Tue, 15 Sep 2020 06:13:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 390907803DF for ; Tue, 15 Sep 2020 06:13:00 +0000 (UTC) Date: Tue, 15 Sep 2020 06:13:00 +0000 (UTC) From: "Marat Abrarov (Jira)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MEAR-216) Unable to include dependencies of type test-jar MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MEAR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195895#comment-17195895 ] Marat Abrarov commented on MEAR-216: ------------------------------------ [~wrungel], what about custom artifact type mappings - [artifactTypeMappings|https://maven.apache.org/plugins/maven-ear-plugin/generate-application-xml-mojo.html#artifactTypeMappings] configuration parameter of ear:generate-application-xml and ear:ear goals? I tried this configuration (upgraded till the latest GA version of Maven EAR Plugin and added artifactTypeMappings option): {code:xml} org.apache.maven.plugins maven-ear-plugin 3.0.2 7 lib true {code} for [^test-jar-in-ear-2.zip] maven project you provided and it works: {noformat} $ mvn clean package ... [INFO] ----------------------< frol:test-jar-in-ear-ear >---------------------- [INFO] Building test-jar-in-ear-ear 1.0-SNAPSHOT [3/3] [INFO] --------------------------------[ ear ]--------------------------------- [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ test-jar-in-ear-ear --- [INFO] [INFO] --- maven-ear-plugin:3.0.2:generate-application-xml (default-generate-application-xml) @ test-jar-in-ear-ear --- [WARNING] Using useBaseVersion not yet fixed. [INFO] Generating application.xml [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ test-jar-in-ear-ear --- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent! [INFO] skip non existing resourceDirectory D:\Users\Marat\Documents\work\java\test-jar-in-ear\ear\src\main\resources [INFO] [INFO] --- maven-ear-plugin:3.0.2:ear (default-ear) @ test-jar-in-ear-ear --- [WARNING] Using useBaseVersion not yet fixed. [INFO] Copying artifact [jar:frol:test-jar-in-ear-lib:1.0-SNAPSHOT] to [lib/frol-test-jar-in-ear-lib-1.0-SNAPSHOT.jar] [INFO] Copying artifact [jar:frol:test-jar-in-ear-lib:tests:1.0-SNAPSHOT] to [lib/frol-test-jar-in-ear-lib-1.0-SNAPSHOT-tests.jar] [INFO] Copy ear sources to D:\Users\Marat\Documents\work\java\test-jar-in-ear\ear\target\test-jar-in-ear-ear-1.0-SNAPSHOT [INFO] Building jar: D:\Users\Marat\Documents\work\java\test-jar-in-ear\ear\target\test-jar-in-ear-ear-1.0-SNAPSHOT.ear [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for test-jar-in-ear-parent 1.0-SNAPSHOT: [INFO] [INFO] test-jar-in-ear-parent ............................. SUCCESS [ 0.194 s] [INFO] test-jar-in-ear-lib ................................ SUCCESS [ 2.390 s] [INFO] test-jar-in-ear-ear ................................ SUCCESS [ 0.892 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 3.655 s (Wall Clock) [INFO] Finished at: 2020-09-15T08:56:36+03:00 [INFO] ------------------------------------------------------------------------ $ cat ear/target/application.xml test-jar-in-ear-ear lib $ unzip -l ear/target/test-jar-in-ear-ear-1.0-SNAPSHOT.ear Archive: ear/target/test-jar-in-ear-ear-1.0-SNAPSHOT.ear Length Date Time Name --------- ---------- ----- ---- 95 09-15-2020 09:04 META-INF/MANIFEST.MF 0 09-15-2020 09:04 META-INF/ 0 09-15-2020 09:04 lib/ 0 09-15-2020 09:04 META-INF/maven/ 0 09-15-2020 09:04 META-INF/maven/frol/ 0 09-15-2020 09:04 META-INF/maven/frol/test-jar-in-ear-ear/ 2076 09-15-2020 09:04 lib/frol-test-jar-in-ear-lib-1.0-SNAPSHOT-tests.jar 381 09-15-2020 09:04 META-INF/application.xml 1684 09-15-2020 08:56 META-INF/maven/frol/test-jar-in-ear-ear/pom.xml 96 09-15-2020 09:04 META-INF/maven/frol/test-jar-in-ear-ear/pom.properties 2082 09-15-2020 09:04 lib/frol-test-jar-in-ear-lib-1.0-SNAPSHOT.jar --------- ------- 6414 11 files {noformat} Refer to [{{org.apache.maven.plugins.ear.util.ArtifactTypeMappingService}}|https://github.com/apache/maven-ear-plugin/blob/maven-ear-plugin-3.0.2/src/main/java/org/apache/maven/plugins/ear/util/ArtifactTypeMappingService.java] class and to [{{org.apache.maven.plugins.ear.util.ArtifactRepository#getArtifacts}}|https://github.com/apache/maven-ear-plugin/blob/maven-ear-plugin-3.0.2/src/main/java/org/apache/maven/plugins/ear/util/ArtifactRepository.java#L138] method which is called by [{{org.apache.maven.plugins.ear.JarModule#resolveArtifact}}|https://github.com/apache/maven-ear-plugin/blob/maven-ear-plugin-3.0.2/src/main/java/org/apache/maven/plugins/ear/JarModule.java#L91] method when generating application.xml and packaging EAR file. > Unable to include dependencies of type test-jar > ----------------------------------------------- > > Key: MEAR-216 > URL: https://issues.apache.org/jira/browse/MEAR-216 > Project: Maven Ear Plugin > Issue Type: Improvement > Affects Versions: 2.10 > Reporter: Maxim Frolov > Priority: Major > Fix For: 3.1.0 > > Attachments: test-jar-in-ear-2.zip, test-jar-in-ear.zip > > > Please implement support for artifacts of type *test-jar*. > One of the use cases would be to build a test EAR as a mix of production and test JARs where the test JARs are used to set up the test data used to test the production code. > Currently including one or more dependencies of type test-jar causes *LifecycleExecutionException*: > {noformat} > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:2.10:generate-application-xml (default-generate-application-xml) on project suite-systemtests-common-ear: Failed to initialize ear modules: Unknown artifact type[test-jar] for artifact_id -> [Help 1] > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:2.10:generate-application-xml (default-generate-application-xml) on project suite-systemtests-common-ear: Failed to initialize ear modules > at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) > at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409) > at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352) > Caused by: org.apache.maven.plugin.MojoExecutionException: Failed to initialize ear modules > at org.apache.maven.plugin.ear.AbstractEarMojo.execute(AbstractEarMojo.java:260) > at org.apache.maven.plugin.ear.GenerateApplicationXmlMojo.execute(GenerateApplicationXmlMojo.java:162) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) > ... 19 more > Caused by: org.apache.maven.plugin.ear.UnknownArtifactTypeException: Unknown artifact type[test-jar] for common-domain-impl > at org.apache.maven.plugin.ear.EarModuleFactory.newEarModule(EarModuleFactory.java:88) > at org.apache.maven.plugin.ear.AbstractEarMojo.execute(AbstractEarMojo.java:250) > ... 22 more > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)