mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave
Date Wed, 20 May 2015 17:48:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33823/#review84529
-----------------------------------------------------------



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135827>

    s/Low-level executor/Executor/



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135828>

    Similar to what we did in scheduler.proto, please have a pointer to the messages below.
    
    e.g.,
    
    SUBSCRIBED = 1; // See 'Subscribed' below.



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135838>

    s/ACKNOWLEDGE/ACKNOWLEDGED/



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135830>

    'executor_id' is a required field in ExecutorInfo. So it will be set. Why did you mention
it specifically here?
    
    Also, note that these are events received by the executor. So any expectations "will be"
set not "must be" set.
    
    Just say that, 'id' field will be set in 'framework_info'.



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135831>

    s/Once received/Once successfully launched/
    
    s/an 'Update'/a TASK_RUNNING 'Update'/



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135832>

    s/received/the task is terminated/



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135833>

    s/scheduler/slave/



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135834>

    s/are also/should also be/
    
    s/it needs to/it re-subscribes/



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135839>

    s/Acknowledge/Acknowledged/



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135835>

    s/case of/case/



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135836>

    s/scheduler/executor/



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135840>

    s/Acknowledge/Acknowledged/
    s/acknowledge/acknowledged/



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135841>

    s/Low-level scheduler/Scheduler/



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135842>

    Similar to events, have pointers to messages below



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135864>

    s/Acknowlede/Acknowledged/



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135867>

    Put this above Update message.
    
    s/Request the slave to be resubscribed/Request to resubscribe with the slave/
    
    s/It includes/It must include/



include/mesos/executor/executor.proto
<https://reviews.apache.org/r/33823/#comment135870>

    Kill this.


- Vinod Kone


On May 20, 2015, 6:41 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33823/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 6:41 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Marco Massenzio, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor/executor.hpp PRE-CREATION 
>   include/mesos/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 
> 
> Diff: https://reviews.apache.org/r/33823/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message