mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.
Date Thu, 28 May 2015 21:53:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review85628
-----------------------------------------------------------

Ship it!


Folks - this thing has been out for almost four months now, we should really get it moving.

@alexdr - can you please address Nik's comments (Nik - you got late to the party :) but that's
ok)

@till - I think Alex addressed your comments, can you please give it a quick once-over and,
unless you see major trouble, can we please commit?

In general, high-level API/protocol isssues should be hashed out during the design state (here's
to hoping we had a Design Doc for this API back in the day: this patch pre-dates me by more
than two months!) so that when we come to the implementation stage, there are no longer discussions
about URI structure, payload, etc.

Thanks everyone for helping moving this forward!

- Marco Massenzio


On May 19, 2015, 8:42 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
> 
> (Updated May 19, 2015, 8:42 a.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Marco Massenzio, Niklas Nielsen, and Till
Toenshoff.
> 
> 
> Bugs: MESOS-2157
>     https://issues.apache.org/jira/browse/MESOS-2157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
> 
> Adds tests for the endpoints.
> 
> Works with [29883](https://reviews.apache.org/r/29883).
> 
> Builds on the abandoned patch 14286.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 
>   src/master/master.hpp da0a83510784f4f7dbd933e666ac12c04c413a62 
>   src/master/master.cpp eaea79df2c693d15087d70b3c9b988e57c894f8e 
>   src/tests/master_tests.cpp ba3858fb3026f2cc7af0523bd1a0c541eeafc34b 
> 
> Diff: https://reviews.apache.org/r/30612/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message