mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.
Date Wed, 01 Jul 2015 00:32:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36061/
-----------------------------------------------------------

(Updated June 30, 2015, 5:32 p.m.)


Review request for mesos, Adam B and Joris Van Remoortere.


Changes
-------

Added MESOS-2962 to the "Bugs" field.


Bugs: MESOS-2962
    https://issues.apache.org/jira/browse/MESOS-2962


Repository: mesos


Description
-------

Jira: MESOS-2962

Slave fails with Abort stacktrace when DNS cannot resolve hostname

If the DNS cannot resolve the hostname for a slave node, we correctly return an Error object,
but we then fail with a segfault.

This code adds a more user-friendly message and exits normally (with an `EXIT_FAILURE` code).
For example, forcing `net::getIp()` to always return an Error, now causes the slave to exit
like this:
```
$ ./bin/mesos-slave.sh --master=10.10.1.121:5405
WARNING: Logging before InitGoogleLogging() is written to STDERR
E0630 11:31:45.777465 1944417024 process.cpp:899] Could not obtain the IP address for stratos.local;
the DNS service may not be able to resolve it: >>> Marco was here!!!

$ echo $?
1
```


Diffs
-----

  3rdparty/libprocess/src/process.cpp d99947c1598c43c47c88ef3e8038081855f0d1dc 

Diff: https://reviews.apache.org/r/36061/diff/


Testing
-------

make check
and manual failing the DNS


Thanks,

Marco Massenzio


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message