mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.
Date Sat, 01 Aug 2015 02:22:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37007/#review93827
-----------------------------------------------------------



include/mesos/hook.hpp (line 89)
<https://reviews.apache.org/r/37007/#comment148220>

    `s/executorID/executorId/` -- here and below.



src/slave/slave.cpp 
<https://reviews.apache.org/r/37007/#comment148221>

    Why did this have to move? I guess we want the `update` within the `if (executor == NULL)`
statement block to have the old value?


- Michael Park


On July 31, 2015, 11:27 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37007/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 11:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3016
>     https://issues.apache.org/jira/browse/MESOS-3016
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently, only FrameworkID and TaskID are sent to the hook.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b 
>   src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf 
>   src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 
>   src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 
>   src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1 
> 
> Diff: https://reviews.apache.org/r/37007/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message