mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 36908: Added QuotaInfo Protobuf.
Date Mon, 03 Aug 2015 14:44:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93908
-----------------------------------------------------------



include/mesos/master/quota.proto (line 25)
<https://reviews.apache.org/r/36908/#comment148337>

    If the guaranteed resource allocation is ALL that QuotaInfo describes, we should rename
it. However, reading on, it seems to me that we want QuotaInfo to describe both the minimum
AND the limit in the long run. So this should be pointed out right here. The TODO further
below comes a bit too late IMHO.



include/mesos/master/quota.proto (line 34)
<https://reviews.apache.org/r/36908/#comment148339>

    s/should/must
    s/Resource.role/guaranteed.role
    s/QuotaInfo.role/the above role



include/mesos/master/quota.proto (line 36)
<https://reviews.apache.org/r/36908/#comment148340>

    s/guaranteed/guarantees



include/mesos/master/quota.proto (line 38)
<https://reviews.apache.org/r/36908/#comment148341>

    limit, bound -> plural


- Bernd Mathiske


On July 29, 2015, 9:59 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 9:59 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3164
>     https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message