mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Review Request 37080: Introduced RecordIO response reader
Date Tue, 04 Aug 2015 16:27:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37080/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos


Description
-------

Added a decorator class over the existing Record-IO decoder in stout (MESOS-3067). The decorator
accepts a Pipe::Reader thereby abstracting away the record reading logic. The future returns
true only when it sees a complete record. This cleaned up the tests as we no longer need to
invoke the stout decoder multiple times till we got atleast one element.

Needed for MESOS-2294 testing.


Diffs
-----

  src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
  src/common/recordio_response.hpp PRE-CREATION 
  src/tests/common/recordio_response_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37080/diff/


Testing
-------

make check + added tests.


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message