mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 36987: Extended 'getFormValue' to 'getFormValues' in order to parse input uniformly.
Date Wed, 05 Aug 2015 10:04:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36987/
-----------------------------------------------------------

(Updated Aug. 5, 2015, 10:04 a.m.)


Review request for mesos, Ben Mahler and Jie Yu.


Bugs: MESOS-2600
    https://issues.apache.org/jira/browse/MESOS-2600


Repository: mesos


Description
-------

`getFormValues` takes a `Request` object and a list of required keys, and tries to return
a map of the required keys to their corresponding values.

This function helps to reduce the amount of code required to check the each required keys
manually as well as to keep the missing parameter error message uniform across multiple endpoints.

This is a short-term solution which improves upon `getFormValue`, but in the future we should
consider adding a libprocess level support for processing the required and optional keys from
a `Request`.


Diffs
-----

  src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 
  src/tests/repair_tests.cpp 4d513ed9e18ebf04a5e5aadb022b064479739e66 

Diff: https://reviews.apache.org/r/36987/diff/


Testing
-------

`make check`


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message