mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 37055: Added Image to Volume as one of the sources.
Date Fri, 07 Aug 2015 23:13:12 GMT


> On Aug. 5, 2015, 4:43 p.m., Timothy Chen wrote:
> > include/mesos/mesos.proto, line 1254
> > <https://reviews.apache.org/r/37055/diff/1/?file=1028034#file1028034line1254>
> >
> >     Should we add some commets around the Image?
> >     Perhaps something like:
> >     
> >     // Image that will be used to provision a new root filesystem by the Image provisioner.

This reads like there is only one provisioner. Maybe just 

```
// Image that will be used to provision a new root filesystem.
```


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37055/#review94327
-----------------------------------------------------------


On Aug. 3, 2015, 4:12 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37055/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2015, 4:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Image to Volume as one of the sources.
> 
> See the motivation here: https://docs.google.com/document/d/1n2emC2ruTMur5nURvLgGYJxuP-tgBwgLDrmg_17QSmA/edit#
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
> 
> Diff: https://reviews.apache.org/r/37055/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message