mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 37315: Added basic authentication documentation
Date Mon, 10 Aug 2015 21:33:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37315/#review94799
-----------------------------------------------------------


Thanks for doing this. Looking pretty good, just some minor comments.


docs/authentication.md (line 25)
<https://reviews.apache.org/r/37315/#comment149415>

    Prefer to use the same language as in master/flags.hpp because that is more clear.



docs/authentication.md (line 26)
<https://reviews.apache.org/r/37315/#comment149416>

    ditto.



docs/authentication.md (lines 39 - 40)
<https://reviews.apache.org/r/37315/#comment149419>

    prefer
    
    s/username/principal/
    
    s/password/secret/
    
    for consistency



docs/authentication.md (line 48)
<https://reviews.apache.org/r/37315/#comment149420>

    ditto. use 'principal1' and 'secret1' instead.



docs/authentication.md (line 54)
<https://reviews.apache.org/r/37315/#comment149418>

    Lets mention that all a framework needs to do is to instantiate the scheduler driver constructor
that takes credential as argument. 
    
    https://github.com/apache/mesos/blob/master/include/mesos/scheduler.hpp#L371
    
    The scheduler driver takes care of authentication for the scheduler.
    
    You can also show the example of test framework using authN.
    
    MESOS_AUTHENTICATE=true DEFAULT_PRINCIPAL=principal2 DEFAULT_SECRET=secret2 ./src/test-framework
--master=127.0.0.1:5050


- Vinod Kone


On Aug. 10, 2015, 9 p.m., Tim Anderegg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37315/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 9 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1838
>     https://issues.apache.org/jira/browse/MESOS-1838
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added basic authentication documentation
> 
> 
> Diffs
> -----
> 
>   docs/authentication.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37315/diff/
> 
> 
> Testing
> -------
> 
> Ran git hook to validate formatting.
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message