mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 37327: Added a recordio::Reader for wrapping an http::Pipe::Reader.
Date Tue, 11 Aug 2015 00:13:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37327/#review94831
-----------------------------------------------------------

Ship it!



src/common/recordio.hpp (line 177)
<https://reviews.apache.org/r/37327/#comment149475>

    do you need to pull this into its own function? it's only used one afaict.



src/common/recordio.hpp (line 207)
<https://reviews.apache.org/r/37327/#comment149472>

    s/failure/error/ ? to be consistent with how we named this elsewhere in the codebase (e.g.,
group.cpp)



src/tests/common/recordio_tests.cpp (line 122)
<https://reviews.apache.org/r/37327/#comment149479>

    can you also write a properly encoded record before and after you write the improper one?
    
    i think that would be a more interesting test case.


- Vinod Kone


On Aug. 10, 2015, 11:41 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37327/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 11:41 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is helpful for the scheduler library and tests. Since we
> currently do not have a generalized abstraction in libprocess
> for "streams" of asynchronous data (e.g. process::Stream<T>),
> we have to create a one-off wrapper here.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 942003149b071a322933e2c085d9122903f69713 
>   src/common/recordio.hpp PRE-CREATION 
>   src/tests/common/recordio_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37327/diff/
> 
> 
> Testing
> -------
> 
> Added tests.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message