mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 37187: Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.
Date Tue, 11 Aug 2015 03:31:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/#review94782
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp (lines 31 - 34)
<https://reviews.apache.org/r/37187/#comment149399>

    Since templated typedefs exist now, let's remove the part about them not existing.
    
    How about something like:
    
    ```
    Provides a hashmap via 'std::unordered_map'. We inherit from it to add new functions as
well as to provide better names for some of the existing functions.
    ```



3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp (line 69)
<https://reviews.apache.org/r/37187/#comment149512>

    `s/template<>/template <>/`


- Michael Park


On Aug. 10, 2015, 12:25 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37187/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 12:25 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
>     https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed hashmap, hashset to use std::unordered_{set,map} instead of boost::unordered_{set,map}.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp ecab60a21765c58b0732de747509aa6382d31c06

>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 2dd1905a4626a7d7e9f61863c8290ae1cdb9b925

>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce

>   3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03

> 
> Diff: https://reviews.apache.org/r/37187/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message