mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 37189: Added std::hash template specializations.
Date Tue, 11 Aug 2015 03:39:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94859
-----------------------------------------------------------


Looks good overall! Same question as [r37188](https://reviews.apache.org/r/37188/): why did
you decide to leave the `hash_value` functions and call it from `std::hash` specializations
rather than moving the logic?


include/mesos/type_utils.hpp (line 493)
<https://reviews.apache.org/r/37189/#comment149514>

    `s/template<>/template <>/`



include/mesos/type_utils.hpp (line 503)
<https://reviews.apache.org/r/37189/#comment149515>

    `s/template<>/template <>/`



include/mesos/type_utils.hpp (line 513)
<https://reviews.apache.org/r/37189/#comment149516>

    `s/template<>/template <>/`



include/mesos/type_utils.hpp (line 523)
<https://reviews.apache.org/r/37189/#comment149517>

    `s/template<>/template <>/`



include/mesos/type_utils.hpp (line 533)
<https://reviews.apache.org/r/37189/#comment149518>

    `s/template<>/template <>/`



src/linux/cgroups.hpp (line 655)
<https://reviews.apache.org/r/37189/#comment149519>

    `s/template<>/template <>/`



src/messages/log.hpp (line 56)
<https://reviews.apache.org/r/37189/#comment149520>

    `{` on the next line.



src/module/manager.hpp (lines 160 - 161)
<https://reviews.apache.org/r/37189/#comment149521>

    This now fits in one line.



src/tests/containerizer.hpp (line 52)
<https://reviews.apache.org/r/37189/#comment149522>

    `s/template<>/template <>/`



src/tests/module.hpp (line 87)
<https://reviews.apache.org/r/37189/#comment149524>

    `s/template<>/template <>/`


- Michael Park


On Aug. 10, 2015, 12:26 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 12:26 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
>     https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added std::hash template specializations.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 
>   src/linux/cgroups.hpp a4a2cae8c0cf537b687897e56176aa44bf8bd21d 
>   src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef 
>   src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75 
>   src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 
>   src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 
>   src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
>   src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 
>   src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 
> 
> Diff: https://reviews.apache.org/r/37189/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message