mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 36404: Added support for peek() to process::io
Date Tue, 18 Aug 2015 03:14:33 GMT


> On July 26, 2015, 6:18 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/src/tests/io_tests.cpp, line 377
> > <https://reviews.apache.org/r/36404/diff/4/?file=1018378#file1018378line377>
> >
> >     we can get rid of some of these literals by:
> >     s/3/sizeof(data)/
> >     What do you think?

I followed what was done in the read test here.


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36404/#review93040
-----------------------------------------------------------


On Aug. 5, 2015, 8:26 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36404/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 8:26 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-2964
>     https://issues.apache.org/jira/browse/MESOS-2964
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> JIRA: https://issues.apache.org/jira/browse/MESOS-2964
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/io.hpp 975923f40f82357f31b89428f24d01df6a8ac9fc

>   3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1 
>   3rdparty/libprocess/src/tests/io_tests.cpp c642b3333ab9e2845668767ad237985cb9ce1109

> 
> Diff: https://reviews.apache.org/r/36404/diff/
> 
> 
> Testing
> -------
> 
> - Added a test case for process::io::peek
> - make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message