mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <liu...@cn.ibm.com>
Subject Re: Review Request 36908: Added QuotaInfo Protobuf.
Date Wed, 26 Aug 2015 02:12:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96482
-----------------------------------------------------------



src/Makefile.am (line 182)
<https://reviews.apache.org/r/36908/#comment151876>

    I mean the file order in Makefile.am should follow alpha order as other part in this file.
    
    My propose is that you only need to re-order the file list here as following:
    
    module/module.pb.cc							\
      ../include/mesos/module/module.pb.h					\
    master/quota.pb.cc							\
      ../include/mesos/master/quota.pb.h					\
      
    Just adjust the order should works.


- Guangya Liu


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3164
>     https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message