mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.
Date Thu, 01 Oct 2015 10:07:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38161/
-----------------------------------------------------------

(Updated Oct. 1, 2015, 10:07 a.m.)


Review request for mesos and Ben Mahler.


Changes
-------

BenM's comments.


Summary (updated)
-----------------

Replaced a hard-coded number for registration backoff with a proper constant.


Repository: mesos


Description (updated)
-------

Prepend a constant regulating the backoff factor with DEFAULT_ prefix for clarity, use it
in tests where appropriate and extend comments for posterity.


Diffs (updated)
-----

  src/sched/constants.hpp ac497b2abc9fbeab713b312cf37963d7de28ed50 
  src/sched/constants.cpp 517ca5cb0dad49d775d65c9ffabc849ff85347a0 
  src/sched/flags.hpp 4e0d56f61b6877254161112b288ae4a9c579e846 
  src/slave/constants.hpp df18676f17f2277e3c38432b76f16c5f9cb08341 
  src/slave/constants.cpp cf3ee7bbc252364a1b73731feab6a9da68ee1f55 
  src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 
  src/tests/fault_tolerance_tests.cpp c97bc4691f9bac4a8677e6d2247be96ee9674b57 

Diff: https://reviews.apache.org/r/38161/diff/


Testing
-------

make check (Mac OS 10.10.4)


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message