mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.
Date Thu, 01 Oct 2015 18:08:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38161/#review101250
-----------------------------------------------------------


Thanks for the patience, almost there! Can we split the `> >` flattening change out
and do a complete pass on the file?


src/tests/fault_tolerance_tests.cpp (lines 650 - 651)
<https://reviews.apache.org/r/38161/#comment158628>

    I don't think we need this second sentence, since the DEFAULT expresses this pretty clearly,
no?



src/tests/fault_tolerance_tests.cpp (lines 706 - 707)
<https://reviews.apache.org/r/38161/#comment158627>

    Ditto here.



src/tests/fault_tolerance_tests.cpp (line 1540)
<https://reviews.apache.org/r/38161/#comment158625>

    I could have committed the `> >` flattening already for you if it was split, also,
it would be be better to do a pass on the entire file in one patch rather than stick in it
alongside the rest of your change, thoughts?



src/tests/fault_tolerance_tests.cpp (lines 1547 - 1551)
<https://reviews.apache.org/r/38161/#comment158623>

    It looks inconsistent to do this here but not in the other tests this patch touches. Now
that the variable name includes DEFAULT, how about we remove the explicit setting here?


- Ben Mahler


On Oct. 1, 2015, 10:07 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38161/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2015, 10:07 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prepend a constant regulating the backoff factor with DEFAULT_ prefix for clarity, use
it in tests where appropriate and extend comments for posterity.
> 
> 
> Diffs
> -----
> 
>   src/sched/constants.hpp ac497b2abc9fbeab713b312cf37963d7de28ed50 
>   src/sched/constants.cpp 517ca5cb0dad49d775d65c9ffabc849ff85347a0 
>   src/sched/flags.hpp 4e0d56f61b6877254161112b288ae4a9c579e846 
>   src/slave/constants.hpp df18676f17f2277e3c38432b76f16c5f9cb08341 
>   src/slave/constants.cpp cf3ee7bbc252364a1b73731feab6a9da68ee1f55 
>   src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 
>   src/tests/fault_tolerance_tests.cpp c97bc4691f9bac4a8677e6d2247be96ee9674b57 
> 
> Diff: https://reviews.apache.org/r/38161/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message