mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 38747: Adding digest utilities
Date Thu, 01 Oct 2015 18:23:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38747/#review101257
-----------------------------------------------------------


Sorry I haven't chimed in earlier. I made one comment earlier with a reference to a pending
review <https://reviews.apache.org/r/34138/> but didn't look at the review closely.
I also have a ticket https://issues.apache.org/jira/browse/MESOS-3191 create before.

I have a few questions, just to help me understand the context.

1) Since the motivation for this util is for computing and verifying docker image hash, how
will we use it? Given that this implementation requires USE_SSL_SOCKET, do we want to tie
the docker provisioner to the --enable-ssl flag? Or should we create another flag or make
`libssl-dev` or `openssl-devel` a dependency by default? What is the plan?

2) What's the advantage of using openssl APIs directly? This implementation is obviously more
complex than the alternative <https://reviews.apache.org/r/34138/>, which simply calls
out to a few widely distributed system binaries on our supported platforms. (sha256sum sha512sum
are part of GNU coreutils while shasum is on every mac). The linked review needs to address
some comments but it's not far from ready for shipit (it's not a priority for us right now
but you can take it if you like).

Thanks!

- Jiang Yan Xu


On Sept. 30, 2015, 1:11 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38747/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 1:11 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added SHA256, SHA512 implementation.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
>   3rdparty/libprocess/include/Makefile.am fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 
>   3rdparty/libprocess/include/process/digest.hpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/CMakeLists.txt a14b5b8fe22d3e75bef3c716ae7865ddaf132927

>   3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38747/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message