mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 38934: Show framework role in webui.
Date Thu, 01 Oct 2015 19:45:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38934/#review101275
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38934]

All tests passed.

- Mesos ReviewBot


On Oct. 1, 2015, 6:31 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38934/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2015, 6:31 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3565
>     https://issues.apache.org/jira/browse/MESOS-3565
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Show framework role in webui.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/framework.html 8c6e5e4e02a769fd0098150b0dcba69f43b20232 
>   src/webui/master/static/frameworks.html 44ef2e55c1e37bb74f769842fe1babffe31a8ea9 
>   src/webui/master/static/slave.html a1446bce827944609faf10f72e788f33d275d6f9 
> 
> Diff: https://reviews.apache.org/r/38934/diff/
> 
> 
> Testing
> -------
> 
> # In master
> ![in_master](https://issues.apache.org/jira/secure/attachment/12764657/add_role_to_webui_1.png)
> 
> # In slave
> ![in_slave](https://issues.apache.org/jira/secure/attachment/12764659/add_role_to_webui_3.png)
> 
> # In framework
> ![in_framework](https://issues.apache.org/jira/secure/attachment/12764658/add_role_to_webui_2.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message