mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38963: Added initial draft of networking user-doc.
Date Fri, 02 Oct 2015 18:31:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/#review101347
-----------------------------------------------------------


A few things you're missing (haven't read the doc yet):

* A link to this from `home.md`.
* You need to generate this diff manually (via `git diff --binary`) and post it.  The image
won't be included otherwise.  (ReviewBot is going to say "bad patch" soon.)
* Make sure you render this using https://github.com/mesosphere/mesos-website-container  (Note
that the image will *not* show up, until https://issues.apache.org/jira/browse/MESOS-3183
is resolved).

- Joseph Wu


On Oct. 2, 2015, 11:08 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38963/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 11:08 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3561
>     https://issues.apache.org/jira/browse/MESOS-3561
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added initial draft of networking user-doc.
> 
> 
> Diffs
> -----
> 
>   docs/images/networking-architecture.png PRE-CREATION 
>   docs/networking.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38963/diff/
> 
> 
> Testing
> -------
> 
> Markdown rendering at https://github.com/karya0/mesos/blob/net-user-doc/docs/networking.md
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message