mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 38941: Moved structs outside RegistryClient
Date Fri, 02 Oct 2015 23:18:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38941/#review101390
-----------------------------------------------------------


Thanks for the small patch! I would have liked to ship this but I can't due to the dependencies
:(


src/slave/containerizer/provisioner/docker/registry_client.hpp (line 62)
<https://reviews.apache.org/r/38941/#comment158786>

    Why ManifestResponse instead of just Manifest?


- Ben Mahler


On Oct. 2, 2015, 4 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38941/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 4 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved:
>   - ManifestResponse
>   - FilesystemLayerInfo
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185

>   src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd

>   src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c

> 
> Diff: https://reviews.apache.org/r/38941/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message