mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 38919: Validation of Docker Image Manifests
Date Mon, 05 Oct 2015 23:27:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38919/#review101555
-----------------------------------------------------------



src/slave/containerizer/provisioner/docker/spec.cpp (line 29)
<https://reviews.apache.org/r/38919/#comment158984>

    define these as const int variables



src/slave/containerizer/provisioner/docker/spec.cpp (line 75)
<https://reviews.apache.org/r/38919/#comment158985>

    use strings::contains



src/slave/containerizer/provisioner/docker/spec.cpp (line 81)
<https://reviews.apache.org/r/38919/#comment158986>

    I Don't think you need to verify the verifiers here, libprocess sha code should handle
this.



src/slave/containerizer/provisioner/docker/spec.cpp (line 137)
<https://reviews.apache.org/r/38919/#comment158987>

    Fix the indent.



src/tests/containerizer/provisioner_docker_tests.cpp (line 383)
<https://reviews.apache.org/r/38919/#comment158993>

    ValidateDockerManigestFsLayersNonEmpty



src/tests/containerizer/provisioner_docker_tests.cpp (line 447)
<https://reviews.apache.org/r/38919/#comment158994>

    Don't need this


- Timothy Chen


On Oct. 5, 2015, 8:51 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38919/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 8:51 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Bugs: MESOS-3099
>     https://issues.apache.org/jira/browse/MESOS-3099
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Validation of Docker Image Manifests
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c

> 
> Diff: https://reviews.apache.org/r/38919/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu14.04 + clang++-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message