mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <cont...@isabeljimenez.com>
Subject Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API
Date Mon, 05 Oct 2015 23:51:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38874/#review101556
-----------------------------------------------------------



src/slave/slave.hpp (line 42)
<https://reviews.apache.org/r/38874/#comment158988>

    we don't need this



src/slave/slave.cpp (line 4054)
<https://reviews.apache.org/r/38874/#comment158989>

    `executor->pid.isSome() && executor->pid.get() != UPID()` ?



src/slave/slave.cpp (line 4069)
<https://reviews.apache.org/r/38874/#comment158990>

    same as above



src/slave/slave.cpp (line 5340)
<https://reviews.apache.org/r/38874/#comment158992>

    same as above


- Isabel Jimenez


On Sept. 30, 2015, 3:39 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38874/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 3:39 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3480
>     https://issues.apache.org/jira/browse/MESOS-3480
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change refactors the Executor struct on Agent and adds support for Executors to
connect via the `api/v1/executor` endpoint on Agent. This is similar to the change done in
Master for the Scheduler HTTP API.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/38874/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message