mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API
Date Tue, 06 Oct 2015 02:22:41 GMT


> On Sept. 30, 2015, 4:25 a.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 5325
> > <https://reviews.apache.org/r/38874/diff/1/?file=1087514#file1087514line5325>
> >
> >     Can you please add some comments here? Just curious why here the state is REGISTERING?
Thanks.

Ideally this would have been an invariant check i.e. CHECK(state != REGISTERING) but it seems
that the PID based executor workflow does not do it too. For consitency between the two removing
this.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38874/#review101071
-----------------------------------------------------------


On Oct. 6, 2015, 2:22 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38874/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 2:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3480
>     https://issues.apache.org/jira/browse/MESOS-3480
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change refactors the Executor struct on Agent and adds support for Executors to
connect via the `api/v1/executor` endpoint on Agent. This is similar to the change done in
Master for the Scheduler HTTP API.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/38874/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message