mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API
Date Tue, 06 Oct 2015 02:22:58 GMT


> On Oct. 5, 2015, 11:51 p.m., Isabel Jimenez wrote:
> > src/slave/slave.hpp, line 42
> > <https://reviews.apache.org/r/38874/diff/1/?file=1087513#file1087513line42>
> >
> >     we don't need this

We need this include as the encoder needs it. We can get away with this but that would entail
converting the old message to unversioned protobuf and then evolving it again ( 2 conversions
) instead of 1 that is the case now.

The same logic exists in the master too for the same reason. We can revisit this later.


> On Oct. 5, 2015, 11:51 p.m., Isabel Jimenez wrote:
> > src/slave/slave.cpp, line 4054
> > <https://reviews.apache.org/r/38874/diff/1/?file=1087514#file1087514line4054>
> >
> >     `executor->pid.isSome() && executor->pid.get() != UPID()` ?

They both mean the same in this context.

https://github.com/apache/mesos/blob/master/3rdparty/libprocess/include/process/pid.hpp#L69


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38874/#review101556
-----------------------------------------------------------


On Oct. 6, 2015, 2:22 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38874/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 2:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3480
>     https://issues.apache.org/jira/browse/MESOS-3480
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change refactors the Executor struct on Agent and adds support for Executors to
connect via the `api/v1/executor` endpoint on Agent. This is similar to the change done in
Master for the Scheduler HTTP API.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/38874/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message