mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors
Date Tue, 06 Oct 2015 16:39:00 GMT


> On Oct. 6, 2015, 6:20 a.m., haosdent huang wrote:
> > src/slave/slave.cpp, line 2479
> > <https://reviews.apache.org/r/38877/diff/2/?file=1087669#file1087669line2479>
> >
> >     Seems this line is incomplete.

It was intentionally left this way to avoid warning as error issues. This would be fixed when
`MESOS-3476` is resolved. (Read comments before)


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38877/#review101614
-----------------------------------------------------------


On Sept. 30, 2015, 6:06 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38877/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 6:06 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
>     https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds the functionality for executors to `Subscribe` via the `api/v1/executor`
endpoint. It also stores a marker file as part of the `Subscribe` call if framework `checkpointing`
is enabled. This can then be used by the agent when recovering to wait for reconnecting back
with the executor.
> 
> Since `Call::Update` is in progress as part of MESOS-3476. I have added a `CHECK` if
a executor tries to send a list of unacknowledged tasks as part of the `Subscribe` call.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
> 
> Diff: https://reviews.apache.org/r/38877/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message