mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.
Date Tue, 06 Oct 2015 17:01:56 GMT


> On Oct. 6, 2015, 3:20 a.m., Cong Wang wrote:
> > src/tests/containerizer/port_mapping_tests.cpp, line 270
> > <https://reviews.apache.org/r/36180/diff/3/?file=1091526#file1091526line270>
> >
> >     traffic_invalid_via_loopback is not good either, because there is no traffic
from an invalid port....

how about `traffice_empty_via_loopback` and `traffic_empty_via_public`


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36180/#review101591
-----------------------------------------------------------


On Oct. 6, 2015, 3:13 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36180/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 3:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Ian Downes, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-2765
>     https://issues.apache.org/jira/browse/MESOS-2765
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Avoid multi writers write to same file in PortMappingIsolatorTests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/port_mapping_tests.cpp feca2043503436ac9abac6017ae9059b3fcbed21

> 
> Diff: https://reviews.apache.org/r/36180/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message