mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 39056: Fix for Mesos master crash due to check failure.
Date Tue, 06 Oct 2015 22:04:21 GMT


> On Oct. 6, 2015, 9:47 p.m., Jie Yu wrote:
> > src/v1/resources.cpp, lines 880-886
> > <https://reviews.apache.org/r/39056/diff/2/?file=1092070#file1092070line880>
> >
> >     Not yours, but too bad we need to duplicate the logic here. I am now sure what
will be the long term plan here. If we have 10 versions, do we need to copy the code 10 times...
That's not good :(
> 
> Mandeep Chadha wrote:
>     I agree !! I already missed src/v1/resources.cpp in my first review request :) 
>     Thanks Neil.

Jie, this is a tech-debt that should not hopefully exist across 10 version iterations :)

On a more serious note, this is the related JIRA :  https://issues.apache.org/jira/browse/MESOS-3404

We intend to work on it as part of the HTTP API epic.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39056/#review101691
-----------------------------------------------------------


On Oct. 6, 2015, 9:33 p.m., Mandeep Chadha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39056/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 9:33 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Check failed due to double comparison : MESOS-3552.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
>   src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e 
>   src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 
> 
> Diff: https://reviews.apache.org/r/39056/diff/
> 
> 
> Testing
> -------
> 
> Added unit test.
> make check successful.
> 
> 
> Thanks,
> 
> Mandeep Chadha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message