mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 39037: Allow description empty in help information.
Date Wed, 07 Oct 2015 22:01:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39037/#review101821
-----------------------------------------------------------



3rdparty/libprocess/src/help.cpp (lines 51 - 54)
<https://reviews.apache.org/r/39037/#comment159317>

    In your last diff you didn't have this change and the one below to conditionally add newlines,
why did you introduce it when changing it to Option?
    
    If we want to change this behavior, let's do it in another patch since it seems independent
from making 'description' optional. Keep independent changes in separate patches :)


- Ben Mahler


On Oct. 7, 2015, 3:04 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39037/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 3:04 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3104
>     https://issues.apache.org/jira/browse/MESOS-3104
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow description empty in help information.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/help.hpp e7dc670648e8abd2fef7be79835f0b71e3e91258

>   3rdparty/libprocess/src/help.cpp 822c0844c61c7cabfca2b0534a5fb40001bd7cc7 
> 
> Diff: https://reviews.apache.org/r/39037/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message