mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 39088: Made shell test locale-independent.
Date Thu, 08 Oct 2015 13:27:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39088/
-----------------------------------------------------------

(Updated Oct. 8, 2015, 1:27 p.m.)


Review request for mesos, Alexander Rojas, Jan Schlicht, and Till Toenshoff.


Changes
-------

Make sure we overwrite set and unset flavors of LC_*


Bugs: MESOS-3517
    https://issues.apache.org/jira/browse/MESOS-3517


Repository: mesos


Description
-------

The test environment does not enforce that we run with a defined locale,
so instead enforce it for our particular use case (here: potentially
localized error messages from shell).


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e


Diff: https://reviews.apache.org/r/39088/diff/


Testing
-------

With German locale installed:

    % LANG=de_DE.UTF-8 make check


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message