mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 39088: Made shell test locale-independent.
Date Thu, 08 Oct 2015 13:27:34 GMT


> On Oct. 8, 2015, 9:52 a.m., Jan Schlicht wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, line 961
> > <https://reviews.apache.org/r/39088/diff/1/?file=1092355#file1092355line961>
> >
> >     s/LANG/LC_ALL
> >     
> >     At https://help.ubuntu.com/community/Locale it is stated that using `LANG` provides
a default value if LC_* has not been set. Some distributions (e.g. Fedora) set LC_* explicitly.
We have to use LC_ALL to make sure that it really is overwritten.

Good catch, fixed now.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39088/#review101883
-----------------------------------------------------------


On Oct. 8, 2015, 1:27 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39088/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 1:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3517
>     https://issues.apache.org/jira/browse/MESOS-3517
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test environment does not enforce that we run with a defined locale,
> so instead enforce it for our particular use case (here: potentially
> localized error messages from shell).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e

> 
> Diff: https://reviews.apache.org/r/39088/diff/
> 
> 
> Testing
> -------
> 
> With German locale installed:
> 
>     % LANG=de_DE.UTF-8 make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message