mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.
Date Mon, 12 Oct 2015 19:48:48 GMT


> On Oct. 12, 2015, 7:26 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt, lines 241-246
> > <https://reviews.apache.org/r/39202/diff/1/?file=1094424#file1094424line241>
> >
> >     Where are you moving this to?
> >     (Or why do we *not* need to build Gmock now?)

Sorry, I didn't add a commit message here in my haste.

Basically: GMock 1.7 includes a new CMake-based build system as an option, alongside the VS
solution. So we just use that instead of the VS solution. By ommitting a build command here
we cause CMake to use its "default" behavior, which is to treat the project as a CMake project.
In VS, this means specifically that GMock becomes "just another C++ project" embedded in the
Mesos solution file. So it's very convenient.

And, btw, the reason we're doing this is because GMock's build is broken on Ubuntu 15 when
you use autotools. So transitioning to CMake has the practical advantage of causing the build
to work on Joris's machine.

As an action item, I will update the commit message to explain this. :) Does that sound good?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39202/#review102300
-----------------------------------------------------------


On Oct. 10, 2015, 4:36 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39202/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2015, 4:36 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Moved libevent, gmock, http-parser to CMake on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt f0de224b0d7924344fb1945b387b728a7241df87

>   3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt PRE-CREATION 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake ee1c74d31e28136bf289f4100d79a8ce568cd3af

>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 60108ff598fb075584196aa3d8e8e66e726c9f2a

>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake ea6db09e1a1aa01450aee93814e07f09feae7ac9

> 
> Diff: https://reviews.apache.org/r/39202/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message