mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <cont...@isabeljimenez.com>
Subject Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'
Date Tue, 13 Oct 2015 08:45:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39098/
-----------------------------------------------------------

(Updated Oct. 13, 2015, 8:45 a.m.)


Review request for mesos and Michael Park.


Changes
-------

review comments


Bugs: MESOS-3560
    https://issues.apache.org/jira/browse/MESOS-3560


Repository: mesos


Description
-------

When decoding the JSON credential file into the Credential protobuf object, the 'secret' which
is in 'bytes' is mapped into base64 string automatically by protobuf from JSON. This creates
an unintended behavior, forcing users to encode in base64 their secret when wanting to pass
a JSON file to the --credentials flag.


Diffs (updated)
-----

  include/mesos/mesos.proto 4a16be1 
  src/examples/java/TestExceptionFramework.java 78720b0 
  src/examples/java/TestFramework.java aad94c0 
  src/tests/credentials_tests.cpp ced27c4 

Diff: https://reviews.apache.org/r/39098/diff/


Testing
-------

make check


Thanks,

Isabel Jimenez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message