mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 39037: Allow description empty in help information.
Date Tue, 13 Oct 2015 20:57:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39037/#review102533
-----------------------------------------------------------

Ship it!


Will get this committed shortly.


3rdparty/libprocess/src/help.cpp (lines 46 - 49)
<https://reviews.apache.org/r/39037/#comment160229>

    Let's take tldr as a const string reference as well and just append the newline to 'help'
directly, I'll make this cleanup for you.


- Ben Mahler


On Oct. 13, 2015, 2:47 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39037/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 2:47 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3104
>     https://issues.apache.org/jira/browse/MESOS-3104
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow description empty in help information.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/help.hpp e7dc670648e8abd2fef7be79835f0b71e3e91258

>   3rdparty/libprocess/src/help.cpp 822c0844c61c7cabfca2b0534a5fb40001bd7cc7 
> 
> Diff: https://reviews.apache.org/r/39037/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message