mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 39096: CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.
Date Tue, 13 Oct 2015 22:13:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39096/#review102541
-----------------------------------------------------------



cmake/CompilationConfigure.cmake (line 69)
<https://reviews.apache.org/r/39096/#comment160240>

    Is the actuall example missing here?


LGTM.

- Artem Harutyunyan


On Oct. 13, 2015, 11:26 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39096/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 11:26 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake d1d75098d0ad655a7dcd74628bffd7ba8547b454 
> 
> Diff: https://reviews.apache.org/r/39096/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message