mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
Date Wed, 14 Oct 2015 13:38:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review102630
-----------------------------------------------------------



src/master/master.hpp (lines 863 - 878)
<https://reviews.apache.org/r/36913/#comment160369>

    I see that there are comments for renaming those functions to add, update, delete or addQuota,
updateQuta, deleteQuota, I think that add/update/delete may be better as all of the functions
are already in QuotaHandler, thoughts? Thanks.


- Guangya Liu


On 十月 14, 2015, 1:28 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> -----------------------------------------------------------
> 
> (Updated 十月 14, 2015, 1:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, and Joris
Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 98e76cee81ab206f3ffe7989711abc38f49c4352 
>   src/Makefile.am 4a0eeb89eb2f3fa5e9fff46e4316e39209884343 
>   src/master/http.cpp 3ca3725302cc831b067a2f69edbda95cd30c2520 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message