mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors
Date Fri, 16 Oct 2015 18:44:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38877/
-----------------------------------------------------------

(Updated Oct. 16, 2015, 6:43 p.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
-------

Instead of directly querying the HTTP marker file in the agent code. Added a indirection to
populate it via `RunState` as the PID workflow does


Bugs: MESOS-3515
    https://issues.apache.org/jira/browse/MESOS-3515


Repository: mesos


Description
-------

This change adds the functionality for executors to `Subscribe` via the `api/v1/executor`
endpoint. It also stores a marker file as part of the `Subscribe` call if framework `checkpointing`
is enabled. This can then be used by the agent when recovering to wait for reconnecting back
with the executor.

Since `Call::Update` is in progress as part of MESOS-3476. I have added a `CHECK` if a executor
tries to send a list of unacknowledged tasks as part of the `Subscribe` call.


Diffs (updated)
-----

  src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
  src/slave/slave.hpp d6e417b1ddde44a557e1e7fb3d22b4fd5bd0d526 
  src/slave/slave.cpp cb2d715d100bcfc76d80663ad13504bd278f1200 

Diff: https://reviews.apache.org/r/38877/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message