mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <>
Subject Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors
Date Tue, 20 Oct 2015 19:06:55 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 20, 2015, 7:06 p.m.)

Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Not send back a ShutDown() to the executor upon a retry subscribe request but just close the
existing connection as per discussion with BenM.

Bugs: MESOS-3515

Repository: mesos


This change adds the functionality for executors to `Subscribe` via the `api/v1/executor`
endpoint. It also stores a marker file as part of the `Subscribe` call if framework `checkpointing`
is enabled. This can then be used by the agent when recovering to wait for reconnecting back
with the executor.

Since `Call::Update` is in progress as part of MESOS-3476. I have added a `CHECK` if a executor
tries to send a list of unacknowledged tasks as part of the `Subscribe` call.

Diffs (updated)

  src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
  src/slave/slave.hpp d6e417b1ddde44a557e1e7fb3d22b4fd5bd0d526 
  src/slave/slave.cpp cb2d715d100bcfc76d80663ad13504bd278f1200 



make check


Anand Mazumdar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message