mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 39043: Added support for HTTP Authentication in Mesos.
Date Wed, 21 Oct 2015 04:05:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review103329
-----------------------------------------------------------



src/master/flags.cpp (line 442)
<https://reviews.apache.org/r/39043/#comment161321>

    s/orload/or load/



src/master/master.cpp (line 555)
<https://reviews.apache.org/r/39043/#comment161343>

    Let's make sure we don't confuse our users by using the same name for the old libprocess
authenticator and the new HTTP authenticator. We should make sure that it is called an "HTTP
authenticator" here and everywhere else we possibly log this type.
    
    s/authenticator/HTTP authenticator/



src/master/master.cpp (line 558)
<https://reviews.apache.org/r/39043/#comment161342>

    ```
     LOG(INFO) << "Using '" << httpAuthenticatorNames[0] << "' HTTP authenticator";
    ```


- Till Toenshoff


On Oct. 20, 2015, 10:30 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 10:30 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3756
>     https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP authenticator
with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials are checked
before the body of the request.
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
>   src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
>   src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
>   src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
>   src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message