mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager
Date Wed, 21 Oct 2015 12:12:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38000/#review103391
-----------------------------------------------------------



3rdparty/libprocess/include/process/process.hpp (line 72)
<https://reviews.apache.org/r/38000/#comment161449>

    s/the/the one



3rdparty/libprocess/include/process/process.hpp (line 83)
<https://reviews.apache.org/r/38000/#comment161450>

    Why aren't we using shared pointers here?



3rdparty/libprocess/include/process/process.hpp (line 91)
<https://reviews.apache.org/r/38000/#comment161451>

    realms plural? Bu there is only one string.



3rdparty/libprocess/src/process.cpp (line 3735)
<https://reviews.apache.org/r/38000/#comment161453>

    Insert blank line


- Bernd Mathiske


On Oct. 21, 2015, 3:47 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38000/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 3:47 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3233
>     https://issues.apache.org/jira/browse/MESOS-3233
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds functions which allows libprocess users to add handlers which require authentication
as well as functions to install and remove authenticators.
> 
> Includes tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/process.hpp 8b086f296c80a43be2edaf496a04dadf0c64251a

>   3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271 
>   3rdparty/libprocess/src/tests/http_tests.cpp d13d3888abbf3db552df4a9f83e54667e598ded9

> 
> Diff: https://reviews.apache.org/r/38000/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message