mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically
Date Wed, 21 Oct 2015 12:52:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/
-----------------------------------------------------------

(Updated Oct. 21, 2015, 2:52 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till Toenshoff.


Changes
-------

Adresses issues by Klaus's review.


Bugs: MESOS-3072
    https://issues.apache.org/jira/browse/MESOS-3072


Repository: mesos


Description
-------

Allows developers to provide their own parameters when loading modules instead of using the
ones provided by the user when loading Mesos. This helps to deal with default modules (those
used when the user doesn't provide any), and for testing of the modules.


Diffs (updated)
-----

  src/examples/example_module_impl.cpp db015cea130701a4e0a6fcb890c79fbb0c02c1ce 
  src/examples/test_module.hpp 0514963b6100a6e9a834f2b9670cebc310918fb8 
  src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
  src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
  src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 

Diff: https://reviews.apache.org/r/38627/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message