mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.
Date Wed, 21 Oct 2015 13:12:32 GMT


> On Oct. 12, 2015, 1:59 p.m., Guangya Liu wrote:
> > include/mesos/authentication/http/basic_authenticator_factory.hpp, line 33
> > <https://reviews.apache.org/r/38950/diff/3/?file=1095330#file1095330line33>
> >
> >     virtual

It is not virtual because the class is not supposed to be inherited nor instantiated, it just
provides two static methods.


> On Oct. 12, 2015, 1:59 p.m., Guangya Liu wrote:
> > src/tests/http_authentication_tests.cpp, lines 19-34
> > <https://reviews.apache.org/r/38950/diff/3/?file=1095339#file1095339line19>
> >
> >     #include <string>
> >     
> >     #include <gtest/gtest.h>
> >     
> >     #include <process/authenticator.hpp>
> >     #include <process/gtest.hpp>
> >     
> >     #include <stout/hashmap.hpp>
> >     #include <stout/hashset.hpp>
> >     
> >     #include "tests/mesos.hpp"
> >     #include "tests/module.hpp"
> >     
> >     #include <mesos/authentication/http/basic_authenticator_factory.hpp>
> >     
> >     #include <mesos/module/http_authenticator.hpp>

We use the following order:

1. C header files (whose with extension `.h`)
2. STL files.
3. Files in alphabetical order.

>From the original patch only `string` is wrong.


> On Oct. 12, 2015, 1:59 p.m., Guangya Liu wrote:
> > src/tests/http_authentication_tests.cpp, lines 42-46
> > <https://reviews.apache.org/r/38950/diff/3/?file=1095339#file1095339line42>
> >
> >     using std::string;
> >     
> >     using mesos::http::BasicAuthenticatorFactory;
> >     
> >     using process::http::Authenticator;

Fix the order but not with the one you mentioned, again we use alphabetical order.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/#review102238
-----------------------------------------------------------


On Oct. 21, 2015, 3:12 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38950/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 3:12 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3756
>     https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds support for modularization of HTTP Authenticators. 
> 
> It includes an example of how to do it with the Basic HTTP Authenticator.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION 
>   include/mesos/module/http_authenticator.hpp PRE-CREATION 
>   src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
>   src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
>   src/examples/test_http_authenticator_module.cpp PRE-CREATION 
>   src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
>   src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
>   src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69 
>   src/tests/http_authentication_tests.cpp PRE-CREATION 
>   src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
>   src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f 
> 
> Diff: https://reviews.apache.org/r/38950/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message