mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <klaus1982...@gmail.com>
Subject Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically
Date Thu, 22 Oct 2015 01:53:14 GMT


> On Oct. 21, 2015, 3:02 p.m., Klaus Ma wrote:
> > src/module/manager.hpp, line 94
> > <https://reviews.apache.org/r/38627/diff/2/?file=1101800#file1101800line94>
> >
> >     Should we merge with `moduleParameters[moduleName]` or replace it? IMO, prefer
to merge them; I'd like to leave it to you and your shepherd.
> 
> Alexander Rojas wrote:
>     I don't understand what you mean with this comment? is the same as the following
one?

for example, if `{a:1, b:2}` in `moduleParameters[moduleName]` and `{b:3, c:4}` in `params`,
what's expected result? `{a:1, b:3, c:4}` or `{b:3, c:4}`.


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/#review103365
-----------------------------------------------------------


On Oct. 21, 2015, 8:52 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38627/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 8:52 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3072
>     https://issues.apache.org/jira/browse/MESOS-3072
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allows developers to provide their own parameters when loading modules instead of using
the ones provided by the user when loading Mesos. This helps to deal with default modules
(those used when the user doesn't provide any), and for testing of the modules.
> 
> 
> Diffs
> -----
> 
>   src/examples/example_module_impl.cpp db015cea130701a4e0a6fcb890c79fbb0c02c1ce 
>   src/examples/test_module.hpp 0514963b6100a6e9a834f2b9670cebc310918fb8 
>   src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
>   src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
>   src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 
> 
> Diff: https://reviews.apache.org/r/38627/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message