mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.
Date Thu, 22 Oct 2015 07:50:20 GMT


> On Oct. 21, 2015, 10:24 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/src/io.cpp, line 27
> > <https://reviews.apache.org/r/39007/diff/3/?file=1093271#file1093271line27>
> >
> >     This should at the very end of stout includes.

Let's keep lexicographical sort with an ASCII code page (which plays nicely with everything
from sort to clang-format) while the discussion for the coding guidelines MESOS-2275 is still
in flux.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39007/#review103486
-----------------------------------------------------------


On Oct. 22, 2015, 7:50 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39007/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 7:50 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
>     https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Switch call sites to using safe strerror_r wrapper.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
>   3rdparty/libprocess/src/poll_socket.cpp 85cd864ebddd72316991a8f2782d3c7c9eebcc54 
>   3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271 
>   3rdparty/libprocess/src/profiler.cpp 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 
>   3rdparty/libprocess/src/subprocess.cpp 459825c188d56d25f6e2832e5a170d806e257d6b 
> 
> Diff: https://reviews.apache.org/r/39007/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message