mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 39223: Added Quota Request Validation Tests.
Date Sun, 25 Oct 2015 08:31:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39223/#review103945
-----------------------------------------------------------



src/tests/master_quota_tests.cpp (line 433)
<https://reviews.apache.org/r/39223/#comment162047>

    s/Set_InvalidRequest/SetInvalidRequest?
    
    Ditto for the following



src/tests/master_quota_tests.cpp (line 564)
<https://reviews.apache.org/r/39223/#comment162049>

    We should unify if use "role1" or role1 for all of the tests



src/tests/master_quota_tests.cpp (line 659)
<https://reviews.apache.org/r/39223/#comment162052>

    new line



src/tests/master_quota_tests.cpp (line 676)
<https://reviews.apache.org/r/39223/#comment162051>

    new line



src/tests/master_quota_tests.cpp (line 694)
<https://reviews.apache.org/r/39223/#comment162050>

    new line


- Guangya Liu


On 十月 23, 2015, 9:10 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39223/
> -----------------------------------------------------------
> 
> (Updated 十月 23, 2015, 9:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see Summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39223/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message