mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.
Date Mon, 26 Oct 2015 22:42:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38883/#review104098
-----------------------------------------------------------



support/apply-reviews.py (line 18)
<https://reviews.apache.org/r/38883/#comment162323>

    With the format string you're using, this note isn't _as_ necessary.  (You could remove
it.)  Ditto with the other similar comments.



support/apply-reviews.py (line 19)
<https://reviews.apache.org/r/38883/#comment162322>

    Note: This would also resolve the issue I had with this line in the previous review.



support/apply-reviews.py (line 41)
<https://reviews.apache.org/r/38883/#comment162326>

    Seems like this could go into the previous review.  Same for the next 2 commenting changes/additions.


- Joseph Wu


On Oct. 22, 2015, 11:18 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38883/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 11:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, and Vinod
Kone.
> 
> 
> Bugs: MESOS-3468
>     https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38883/diff/
> 
> 
> Testing
> -------
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message