mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 37853: Overlay filesystem provisioning backend
Date Wed, 28 Oct 2015 03:55:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37853/#review104245
-----------------------------------------------------------


Bad patch!

Reviews applied: [37853]

Failed command: ./support/apply-review.sh -n -r 37853

Error:
 2015-10-28 03:55:33 URL:https://reviews.apache.org/r/37853/diff/raw/ [12573/12573] ->
"37853.patch" [1]
Successfully applied: Overlay filesystem provisioning backend

Implemented the overlay filesystem backend by layering the images as a read-only filesystem.


Review: https://reviews.apache.org/r/37853
Checking 4 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
src/tests/containerizer/provisioner_backend_tests.cpp:34:  Weird number of spaces at line-start.
 Are you using a 2-space indent?  [whitespace/indent] [3]
Total errors found: 1
Failed to commit patch

- Mesos ReviewBot


On Oct. 28, 2015, 3:39 a.m., Mei Wan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37853/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 3:39 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2971
>     https://issues.apache.org/jira/browse/MESOS-2971
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the overlay filesystem backend by layering the images as a read-only filesystem.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 6c7519b 
>   src/Makefile.am d6eb302 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 35ced4b 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 3347d58 
> 
> Diff: https://reviews.apache.org/r/37853/diff/
> 
> 
> Testing
> -------
> 
> I haven't done any official testing. When I was working off Ian's branch, I tested it
manually and the provisioning works.
> 
> 
> Thanks,
> 
> Mei Wan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message