mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 39834: Made `path_tests.cpp` standalone.
Date Sun, 01 Nov 2015 00:50:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/#review104646
-----------------------------------------------------------


Bad patch!

Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 39560, 39583, 39584,
39620, 39621, 39622, 39623, 39019, 39802, 39803]

Failed command: ./support/apply-review.sh -n -r 39803

Error:
 2015-11-01 00:50:37 URL:https://reviews.apache.org/r/39803/diff/raw/ [18127/18127] ->
"39803.patch" [1]
Successfully applied: Windows: Implemented stout/os/stat.hpp`.

Windows: Implemented stout/os/stat.hpp`.


Review: https://reviews.apache.org/r/39803
Checking 4 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp:109:  Redundant blank
line at the end of a code block should be deleted.  [whitespace/blank_line] [3]
Total errors found: 1
Failed to commit patch

- Mesos ReviewBot


On Nov. 1, 2015, 12:28 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39834/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2015, 12:28 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made `path_tests.cpp` standalone.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp ad9ce324eaf940f68d04c6db7ba37d05efb1216a

> 
> Diff: https://reviews.apache.org/r/39834/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message