mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 39805: Moved filesystems tests to their own file.
Date Sun, 01 Nov 2015 01:25:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39805/#review104648
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/Makefile.am (line 45)
<https://reviews.apache.org/r/39805/#comment162892>

    Oh, interesting, I thought that the lineup here was identical to that of `git diff`. I
guess not.


- Alex Clemmer


On Nov. 1, 2015, 1:22 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39805/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2015, 1:22 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved filesystems tests to their own file.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 76e1674e08bbe65a4fdf86731823a61f231d6d12

>   3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp 8934ba79685685d5f5eae5991057c6ad3c8eea8e

>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 26e1377ee625748b7fdbec327fef9ac602535f83

>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff

> 
> Diff: https://reviews.apache.org/r/39805/diff/
> 
> 
> Testing
> -------
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message